feat(wallet): add help for wallet cli commands #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
previously approved these changes
Jun 6, 2022
stringhandler
force-pushed
the
st-wallet-cli
branch
from
6f298aa to
00a30f0
Compare
sdbondi
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts all wallet commands to use clap instead, providing help when called with
--helpregister_assetand other asset-y commandsMotivation and Context
This is IMHO a much cleaner and extendible way of calling commands and seeing what the required fields are. It also allows defaults to be added (e.g. default, overrideable messages)
How Has This Been Tested?
manually