Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): new cli commands to initialise proposals and amendments #4205

Merged
merged 4 commits into from
Jun 20, 2022
Merged

feat(wallet): new cli commands to initialise proposals and amendments #4205

merged 4 commits into from
Jun 20, 2022

Conversation

mrnaveira
Copy link
Contributor

Description

  • Created a new init-update-proposal subcommand to create a proposal JSON file.
    • The fields are very similar to a constitution, only the proposal_id is new.
    • For now, the signature is set to the default value. In the future we will need to implement a way for the user to be able to sign the proposal via a private key.
  • Create a new init-amendment subcommand to create an amendment JSON file.
    • The user is required to specify an update proposal JSON file path with the proposal to amend.
    • Asks for the activation_window to the user, which specifies the amount of blocks until the changes are enforced by the base layer.
    • For now, the list of signatures for each accepting committee member is set as empty. In the future we will need to retrieve those from the acceptance transactions themselves.
  • Renamed the contract command handling function for name consistency.

Motivation and Context

We want an easy way to initialise both contract update proposals and amendments JSON files, to publish them later with other CLI commands.

How Has This Been Tested?

Manually

brianp
brianp approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, untested.

@stringhandler stringhandler merged commit 40cbd50 into tari-project:development Jun 20, 2022
sdbondi added a commit to sdbondi/tari that referenced this pull request Jun 20, 2022
@sdbondi
Merge branch 'development' into wallet-contract-def-init-keymanager
0a7df24 
* development:
  feat(wallet): new cli commands to initialise proposals and amendments (tari-project#4205)
  feat: add an encrypted value to the TransactionOutput (tari-project#4148)
  feat: use tari_crypto's updated "extended pedersen commitment factory" (tari-project#4206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

@brianp brianp brianp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrnaveira @brianp @stringhandler