feat(wallet): adds contract_id to outputs db #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
wallet-add-contract-id-column
branch
from
39a0b1c to
cff32e1
Compare
| @@ -37,7 +37,7 @@ chrono = { version = "0.4.19", default-features = false, features = ["serde"] } | |||
| clear_on_drop = "=0.2.4" | |||
| crossbeam-channel = "0.5.4" | |||
| derivative = "2.2.0" | |||
| diesel = { version = "1.4.8", features = ["sqlite", "serde_json", "chrono"] } | |||
| diesel = { version = "1.4.8", features = ["sqlite", "serde_json", "chrono", "64-column-tables"] } | |||
There was a problem hiding this comment.
This usually increases compile time by a large amount. Can we drop a column maybe to fit into 32?
There was a problem hiding this comment.
The CI didn't seem to take too long, so maybe not so bad
There was a problem hiding this comment.
Yeah we can drop parent_pk and/or unique_id later and remove this feature.
stringhandler
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
contract_idto outputs table in wallet dbflagstooutput_typein wallet dbMotivation and Context
There are various use cases that will require to select outputs by contract_id.
The outputs table now exceeds 32 columns, so the
64-column-tablediesel feature needed to be added.How Has This Been Tested?
Manually, contract id is populated