feat: add sender to instructions #4234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
force-pushed
the
st-val-merge1
branch
from
9b40f56 to
8bb1604
Compare
sdbondi
approved these changes
Jun 28, 2022
| @@ -78,6 +81,10 @@ impl Instruction { | |||
| &self.args | |||
| } | |||
|
|
|||
| pub fn sender(&self) -> PublicKey { | |||
There was a problem hiding this comment.
nit: this naming convention usually means a reference to the item is returned.
Suggest either to_sender_public_key or return a reference.
There was a problem hiding this comment.
Ah yeah, I thought it was Copy for some reason....
brianp
approved these changes
Jun 28, 2022
SWvheerden
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sender to DAN instructions
NOTE: I also created new schema.rs and config file for generating the global db with diesel. See dan_layer/storage_sqlite/README.md