Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vn): scan and save contracts without autoaccept #4265

Conversation

brianp
Copy link
Contributor

@brianp brianp commented Jul 5, 2022

Description

The VN was only scanning and saving contract if autoaccept was enabled. It should still scan and save, just not accept the contracts without autoaccept.

Motivation and Context

Noticed the wrong behaviour while working alongside the code.

How Has This Been Tested?

Integration tests still pass

Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviator-app aviator-app bot removed the mq-failed label Jul 6, 2022
@aviator-app aviator-app bot merged commit a137f53 into tari-project:development Jul 6, 2022
@brianp brianp deleted the save-scanned-contracts-without-autoaccept branch February 13, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants