feat: remove recovery byte #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
previously approved these changes
Jul 12, 2022
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_remove_recovery_byte
branch
from
c5acde7 to
811bfa7
Compare
stringhandler
previously approved these changes
Jul 13, 2022
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_remove_recovery_byte
branch
from
3045822 to
4e400e8
Compare
Removed recovery byte from the output features due to the recently added encrypted value to a transaction output being able to fulfil the original intent of the recovery byte, i.e. to let a wallet pinpoint the UTXO's it owns.
hansieodendaal
force-pushed
the
ho_remove_recovery_byte
branch
from
4e400e8 to
6ed8989
Compare
stringhandler
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed recovery byte from the output features due to the recently added
encrypted value to a transaction output being able to fulfil the original
intent of the recovery byte, i.e. to let a wallet pinpoint the UTXO's it
owns.
Motivation and Context
Recovery byte is not needed anymore.
How Has This Been Tested?
Unit tests
Integration tests