feat: remove hashing domain and update key manager #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_remove_hashing_domain
branch
from
84ceff5 to
6e4cfa9
Compare
hansieodendaal
changed the title
hansieodendaal
force-pushed
the
ho_remove_hashing_domain
branch
2 times, most recently
from
b0450f4 to
b8a8f2d
Compare
hansieodendaal
changed the title
- Removed hashing domain in favour of recent changes in `tari_crypto "v0.15.3"`. - Added a specialized marker trait for tight coupling of `DomainSeparatedHasher` to `Digest`; this is useful when a low level hashing function that accepts `Digest` as type needs to guarantee that domain separated hashing is implemented. - Added a MAC domain hasher that guarantees implementation of `DomainSeparatedHasher` and `LengthExtensionAttackResistant`. - Upadated the key manager to use the MAC domain hasher and to implement the `LengthExtensionAttackResistant` trait.
hansieodendaal
force-pushed
the
ho_remove_hashing_domain
branch
from
b8a8f2d to
6c680dd
Compare
stringhandler
approved these changes
Aug 2, 2022
| DomainSeparatedHasher::<Blake256, KeyManagerHashDomain>::new("cipher_seed.chacha20_encoding") | ||
| } | ||
| hash_domain!( | ||
| KeyManagerMacGeneration, |
There was a problem hiding this comment.
Suggested change
| KeyManagerMacGeneration, | |
| KeyManagerMacGenerationDomain, |
| 1 | ||
| ); | ||
| hash_domain!( | ||
| KeyManagerArgon2Encoding, |
There was a problem hiding this comment.
Suggested change
| KeyManagerArgon2Encoding, | |
| KeyManagerArgon2EncodingDomain, |
| 1 | ||
| ); | ||
| hash_domain!( | ||
| KeyManagerChacha20Encoding, |
There was a problem hiding this comment.
Suggested change
| KeyManagerChacha20Encoding, | |
| KeyManagerChacha20EncodingDomain, |
| @@ -495,7 +503,7 @@ async fn test_utxo_selection_no_chain_metadata() { | |||
|
|
|||
| // test if a fee estimate would be possible with pending funds included | |||
| // at this point 52000 uT is still spendable, with pending change incoming of 1690 uT | |||
| // so instead of returning "not enough funds", return "funds pending" | |||
| // so instead of returning "not enough funds".to_string(), return "funds pending" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tari_crypto "v0.15.3".DomainSeparatedHashertoDigest; this is useful when a low level hashing function that acceptsDigestas type needs to guarantee that domain separated hashing is implemented.DomainSeparatedHasherandLengthExtensionAttackResistant.LengthExtensionAttackResistanttrait.Motivation and Context
See above
How Has This Been Tested?
Passed unit tests
Passed cucumber tests