fix: wallet seed_words command is broken (see issue #4363) #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le wallet's gRPC server implementation Signed-off-by: Andrei Gubarev <agubarev@users.noreply.github.com>
sdbondi
approved these changes
Aug 2, 2022
| self.output_manager_service.remove_encryption().await?; | ||
| self.transaction_service.remove_encryption().await?; | ||
| self.key_manager_service.remove_encryption().await?; | ||
| self.db.remove_encryption().await?; |
There was a problem hiding this comment.
Let's rather not sneak this in :)
There was a problem hiding this comment.
Been waiting for another PR for days, you got me :)
| @@ -1205,47 +1206,38 @@ impl wallet_server::Wallet for WalletGrpcServer { | |||
| } | |||
| } | |||
|
|
|||
| /// Returns the contents of a seed words file, provided via CLI | |||
| async fn seed_words(&self, _: Request<tari_rpc::Empty>) -> Result<Response<SeedWordsResponse>, Status> { | |||
| let cli = Cli::parse(); | |||
There was a problem hiding this comment.
TODO: Cli::parse should (ideally) not be used in GRPC, rather the ApplicationConfig should be made available to the GRPC server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4363
Motivation and Context
Seed word command is broken on GRPC
thread 'tokio-runtime-worker' panicked at 'calledOption::unwrap()on aNonevalue', applications/tari_console_wallet/src/grpc/wallet_grpc_server.rs:1210:50How Has This Been Tested?