Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge grpc list headers commands #4515

Merged
merged 3 commits into from
Aug 25, 2022
Merged

feat: merge grpc list headers commands #4515

merged 3 commits into from
Aug 25, 2022

Conversation

SWvheerden
Copy link
Collaborator

Description

The GRPC server has 2 methods, getHeaderByHeight and getHeaderByHeight.
These 2 methods are especially duplicated, this removes getHeaderByHeight method and adds the additional fields that this method had to getHeaderByHeight

Fixes: #4372

@stringhandler stringhandler merged commit 18a88d7 into tari-project:development Aug 25, 2022
This was referenced Aug 29, 2022
Merged
Merged
stringhandler pushed a commit that referenced this pull request Aug 29, 2022
@sdbondi
fix(cucumber): handles listHeaders response correctly (#4551)
3958dde 
Description
---
- Fixes how listHeaders GRPC response is handled (since #4515)

Motivation and Context
---
#4515 returns the header in a nested struct, this PR updates the js code to handle that correctly.

How Has This Been Tested?
---
`Pruned node should prune outputs` passes
@SWvheerden SWvheerden deleted the sw_merger_gprc_header_commands branch August 31, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi approved these changes

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GRPC[base node]: ListHeaders and GetHeadersByHeight do the same thing
3 participants
@SWvheerden @sdbondi @stringhandler