fix: sync handling and increase reorg speed in mempool #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
changed the title
CjS77
added
the
CR-insufficient_context
SWvheerden
force-pushed
the
sw_fix_sync_handling
branch
from
16ef9dd to
9a2c0aa
Compare
|
Helps to alleviate issues logged in #3115 as observed with system-level stress testing |
hansieodendaal
previously approved these changes
Sep 23, 2022
| }, | ||
| BlockSyncComplete(tip_block) => { | ||
| self.mempool.process_published_block(tip_block.to_arc_block()).await?; | ||
| BlockSyncRewind(_) => {}, |
| self.mempool.process_published_block(tip_block.to_arc_block()).await?; | ||
| BlockSyncRewind(_) => {}, | ||
| BlockSyncComplete(_,_) => { | ||
| self.mempool.process_sync().await?; |
sdbondi
approved these changes
Sep 23, 2022
stringhandler
pushed a commit
that referenced
this pull request
Sep 27, 2022
Description --- Adds in the ability to retrigger the mempool sync if a larger re_org or block sync occurred. Motivation and Context --- As of #4706 the mempool will now properly handle re-orgs and block syncs. But when the base_node is not at the "correct" tip its mempool will reject all invalid transactions. In order to get those transactions back, we need to trigger a mempool sync. This adds in a new config setting to control the maximum number of blocks the base_node added during a reorg or sync before it starts a sync process. The assumption is that in most cases, the blocks removed will be less or the same as the blocks added, so we only need to look at the blocks added. Open Questions --- Do we just sync to one peer, or do we sync to `initial_sync_num_peers` peer? Prerequisite ---- Requires: #4706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the handling reorgs and syncs in the mempool.
The reorg code is updated to remove unnecessary checks when handling reorgs.
The sync code is completely redone to now only listen for a sync completed status. As of now the mempool ignores the rewind event as the mempool knows this is not the final state, either the base node will forward to a new tip or reset itself to the old tip. The base node upon receiving sync completed event will re-evaluate all transactions inside of it and reset it state to the correct state.
There will be a followup pr to add mempool sync