fix(wallet)!: use KDFs on ECDH shared secrets #4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
changed the title
CjS77
added
P-acks_required
|
I like this approach, also getting rid of repetitive key hashing. |
stringhandler
changed the title
|
Thanks. This looks like it is a breaking change. Please add a |
AaronFeickert
changed the title
stringhandler
added
W-transaction-breaking
AaronFeickert
force-pushed
the
fix-output-scanning-kdfs
branch
from
b506a3d to
d48f3ae
Compare
stringhandler
approved these changes
Nov 8, 2022
|
utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses KDFs on ECDH shared secrets for output generation. Closes issue 4717.
Motivation and Context
Several uses of ECDH shared secrets in the output manager and transaction services parse an ECDH shared secret as a scalar spending key, and use this as input to a chain of hash functions for use in rewinding and value encryption. This is non-standard.
This work uses separate KDFs to independently produce a spending key, rewind key, and value encryption key from a
DiffieHellmanSharedSecret-type ECDH shared secret.How Has This Been Tested?
Existing tests pass.
BREAKING CHANGE: Changes the way output keys are derived.