fix!: prune mode sync #5124
Merged
fix!: prune mode sync #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failing |
CjS77
added
P-acks_required
stringhandler
approved these changes
Jan 18, 2023
CjS77
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the syncing of pruned nodes
Motivation and Context
The utxo and kernel keys are stored as LE bytes, but when reading with the order, they need to be BE bytes to return them in the same order as they were written. When we retrieve these for normal block sync, we call
.sort()on them with the construction of the block so the order does not matter.But prune mode streams the utxo and kernels via MMR positions. For this, the order is important and needs to be returned in the same order as requested.
This broke to do no cucumber tests testing prune mode sync. This should be fixed when enabling pruned mode.
How Has This Been Tested?
Manual and new unit tests.
Fixes: #5099
REQUIRES THAT BASE NODES RESYNC AND RECALCULATE DB KEYS