Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet get balance behavior inconsistent #5185

Closed
SWvheerden opened this issue Feb 15, 2023 · 1 comment
Closed

Wallet get balance behavior inconsistent #5185

SWvheerden opened this issue Feb 15, 2023 · 1 comment
Assignees
@SWvheerden
Labels
A-mobile_wallet Area - related to Aurora, the mobile wallet A-wallet Area - related to the wallet A-wallet-ffi Area - Related to the wallet FFI lib

Comments

@SWvheerden
Copy link
Collaborator

The wallet get_balance query returns 4 values: available, time-locked, pending incoming, and pending outgoing.
The problem with the available is that it includes the time-locked, so users have to manually subtract the time-locked from the available to get the actual available balance.

This was fixed for the GRPC in ##5181 (review)

We need to change the root get_balance SQL query to reflect this and propagate this change through the callees like the console wallet and FFI.
@SWvheerden SWvheerden added A-mobile_wallet Area - related to Aurora, the mobile wallet A-wallet Area - related to the wallet A-wallet-ffi Area - Related to the wallet FFI lib labels Feb 15, 2023
@SWvheerden SWvheerden moved this to Should Do in Tari Esme Testnet Mar 28, 2023
@SWvheerden SWvheerden self-assigned this Feb 20, 2024
@SWvheerden
Copy link
Collaborator Author

Fixed in #6158

@github-project-automation github-project-automation bot moved this from Should Do to Done in Tari Esme Testnet Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWvheerden SWvheerden

Labels
A-mobile_wallet Area - related to Aurora, the mobile wallet A-wallet Area - related to the wallet A-wallet-ffi Area - Related to the wallet FFI lib
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SWvheerden