Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce warn log to debug in utxo scanner #5256

Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix: reduce warn log to debug in utxo scanner #5256

merged 1 commit into from
Mar 20, 2023

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Mar 17, 2023 •
edited
Loading

Description

Reduces debug log in scanner from WARN to DEBUG
Reduces select_utxos selection criteria: {} log to DEBUG

Motivation and Context

Lots of false warning messages in cucumber logs

07:51 WARN  Last scanned block found at height 30 (Header Hash: a55cf603f5cdad623e7e2355535d79d1af02c7c6f04ca7b5e44dd113bd0d9d5a) 
07:51 WARN  Last scanned block found at height 32 (Header Hash: 676377e924ea94afdd2297607b10c0aeb1c8ad4e93d57f27fdb3842cd0ae8e1b)
07:51 WARN  Last scanned block found at height 33 (Header Hash: 3697fc22292f1eeb828c83bfa5281542cbfc3996b06985209ff1a7edfd2fd8be)

WARN  select_utxos selection criteria: filter: Standard, ordering: Default

How Has This Been Tested?

N/A

What process can a PR reviewer use to test or verify this change?

Less warning messages in CI

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

stringhandler
stringhandler approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad. thanks

@sdbondi
Copy link
Member Author

sdbondi commented Mar 17, 2023

lol, the blame says it was my code :)

@SWvheerden SWvheerden merged commit 3946641 into tari-project:development Mar 20, 2023
SWvheerden added a commit to SWvheerden/tari that referenced this pull request Mar 20, 2023
@SWvheerden
## [0.49.0-pre.3](tari-project/tari@v0.49.0-pre.2...v0.49.0-pre.3) (2…
3910493 
…023-03-20)

### Bug Fixes

* reduce warn log to debug in utxo scanner ([tari-project#5256](tari-project#5256)) ([3946641](tari-project@3946641))
* wallet sending local address out to network ([tari-project#5258](tari-project#5258)) ([6bfa6f9](tari-project@6bfa6f9))
@SWvheerden SWvheerden mentioned this pull request Mar 20, 2023
Merged
SWvheerden added a commit that referenced this pull request Mar 20, 2023
@SWvheerden
chore(version): v0.49.0-pre.3 (#5259)
9b6c05c 
##
[0.49.0-pre.3](v0.49.0-pre.2...v0.49.0-pre.3)
(2023-03-20)

### Bug Fixes

* reduce warn log to debug in utxo scanner
([5256](#5256))
([3946641](3946641))
* wallet sending local address out to network
([5258](#5258))
([6bfa6f9](6bfa6f9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdbondi @SWvheerden @stringhandler