fix: wallet sending local address out to network #5258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
previously approved these changes
Mar 20, 2023
sdbondi
previously approved these changes
Mar 20, 2023
SWvheerden
force-pushed
the
sw_hot_fix_comms
branch
from
c2326f3 to
195f487
Compare
sdbondi
previously approved these changes
Mar 20, 2023
sdbondi
approved these changes
Mar 20, 2023
SWvheerden
added a commit
to SWvheerden/tari
that referenced
this pull request
Mar 20, 2023
…023-03-20) ### Bug Fixes * reduce warn log to debug in utxo scanner ([tari-project#5256](tari-project#5256)) ([3946641](tari-project@3946641)) * wallet sending local address out to network ([tari-project#5258](tari-project#5258)) ([6bfa6f9](tari-project@6bfa6f9))
SWvheerden
added a commit
that referenced
this pull request
Mar 20, 2023
4 tasks
SWvheerden
pushed a commit
that referenced
this pull request
Mar 22, 2023
Description --- Reverts and freezes `wasm-pack@0.10.3` due to an apparent upstream issue. Fixes (at least temporarily) [issue 5261](#5261). Motivation and Context --- There's an apparent issue with the `wasm-pack` Node.js module at the 0.11.0 version that breaks CI operations (and which [also affects](tari-project/tari-crypto#174) `tari-crypto`). While an [earlier PR](#5258) disabled this CI, it seems unnecessary and somewhat risky not to have these tests. Reverting to the 0.10.3 version is at least a temporary fix. How Has This Been Tested? --- With the fix, CI should pass. What process can a PR reviewer use to test or verify this change? --- Run the equivalent commands locally, and ensure that CI passes with the change. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the wallet sending out
/ip4/0.0.0.0as its address to a base_node as its addressMotivation and Context
0.0.0.0is a local address and when connecting to the a base_node the base_node rejects the wallet with:InvalidMultiaddr("Non-global IP addresses are invalid")How Has This Been Tested?
Manual
Breaking Changes