Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create core code for revealed value outputs, with console wallet interface #5403

Closed
hansieodendaal opened this issue May 23, 2023 · 1 comment

Comments

@hansieodendaal
Copy link
Contributor

hansieodendaal commented May 23, 2023

I think we need some new tests for:

  1. receiving onesided payments with revealed values
  2. block and mempool validation for revealed values
  3. recovery of interactive and one-sided payments with revealed values

Must do ^^

Originally posted by @hansieodendaal in #5372 (comment)

The fees must be more for revealed value proofs. Bulletproof+ type proofs must be the default.

Some notes for implementation:

  • In UnblindedOutput:
    • Add pub fn as_revealed_value_transaction_output with internal test verify_range_proof on output before returning (supporting metadata_signature must be pre-existing)
  • In UnblindedOutputBuilder:
    • pub fn try_build must run the new pub fn as_revealed_value_transaction_output before returning
  • pub fn create_receiver_partial_metadata_signature and pub fn create_metadata_signature will create the correct version of the signature based on output_features
@hansieodendaal hansieodendaal moved this to Backlog in Tari Esme Testnet May 23, 2023
@SWvheerden SWvheerden moved this from Backlog to Bugs in Tari Esme Testnet May 30, 2023
@SWvheerden SWvheerden moved this from Bugs to Must Do in Tari Esme Testnet May 30, 2023
@SWvheerden SWvheerden added the P-high-risk Process - High risk label Nov 17, 2023
@SWvheerden SWvheerden removed the P-high-risk Process - High risk label Nov 29, 2023
@SWvheerden
Copy link
Collaborator

Going to close this for now.
New coinbases are revealed value by default now. We don't allow revealed values for non coinbase atm.

@github-project-automation github-project-automation bot moved this from Must Do to Done in Tari Esme Testnet Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants