fix(comms): only set final forward address if configured to port 0 #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 12 suites +12 25m 14s ⏱️ + 25m 14s For more details on these failures, see this check. Results for commit 94f3e6e. ± Comparison against base commit c704890. ♻️ This comment has been updated with latest results. |
stringhandler
approved these changes
May 24, 2023
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
added a commit
that referenced
this pull request
May 25, 2023
…5406) Description --- Sets the onion service forward address to the correct port only if configured to port 0. Motivation and Context --- Fixes #5405 How Has This Been Tested? --- Manually, default settings were also tested. What process can a PR reviewer use to test or verify this change? --- ```toml # This doesnt work (no incoming connections as expected) #tor.forward_address = "/dns4/localhost/tcp/12345" # This does work tor.forward_address = "/ip4/10.71.1.141/tcp/12345" tor.listener_address_override = "/ip4/10.71.1.141/tcp/12345" ``` Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain --> Co-authored-by: SW van Heerden <swvheerden@gmail.com>
SWvheerden
added a commit
that referenced
this pull request
May 29, 2023
## [0.50.0-pre.2](v0.50.0-pre.1...v0.50.0-pre.2) (2023-05-29) ### ⚠ BREAKING CHANGES * add optional range proof types (5372) ### Features * add metadata signature check ([5411](#5411)) ([9c2bf41](9c2bf41)) * add optional range proof types ([5372](#5372)) ([f24784f](f24784f)) * added burn feature to the console wallet ([5322](#5322)) ([45685b9](45685b9)) * improved base node monitoring ([5390](#5390)) ([c704890](c704890)) ### Bug Fixes * **comms:** only set final forward address if configured to port 0 ([5406](#5406)) ([ff7fb6d](ff7fb6d)) * deeplink to rfc spec ([5342](#5342)) ([806d3b8](806d3b8)) * don't use in memory datastores for chat client dht in integration tests ([#5399](#5399)) ([cbdca6f](cbdca6f)) * fix panic when no public addresses ([5367](#5367)) ([49be2a2](49be2a2)) * loop on mismatched passphrase entry ([5396](#5396)) ([ed120b2](ed120b2)) * use domain separation for wallet message signing ([5400](#5400)) ([7d71f8b](7d71f8b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the onion service forward address to the correct port only if configured to port 0.
Motivation and Context
Fixes #5405
How Has This Been Tested?
Manually, default settings were also tested.
What process can a PR reviewer use to test or verify this change?
Breaking Changes