fix(comms+dht): mark peers as online inbound connection,join

[sdbondi]

Description

• mark peers as online inbound connection and on join msg
• fix DHT peer query logic

Motivation and Context

Peers were not being marked as online whenever we have proof that they are online, specifically in the inbound connection and join msg.

The peer query to exclude peers if we have attempted them but never succeeded was incorrect and filtered out most peers. This was changed to

 // we have tried to connect to this peer, and we have never made a successful attempt at connection
if peer.last_connect_attempt().is_some() && peer.last_seen().is_none() {
    return false;
}

How Has This Been Tested?

Manually, node reconnects quickly to peers on startup

What process can a PR reviewer use to test or verify this change?

Breaking Changes

• None
• Requires data directory on base node to be deleted
• Requires hard fork
• Other - Please specify

[github-actions]

Test Results (CI)

1 199 tests   1 199 ✔️  10m 10s ⏱️
     38 suites         0 💤
       1 files           0 ❌

Results for commit 837bed2.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (Integration tests)

27 tests   27 ✔️  12m 41s ⏱️
11 suites    0 💤
  2 files      0 ❌

Results for commit 837bed2.

♻️ This comment has been updated with latest results.