feat(chat): read receipt feature #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
brianp
force-pushed
the
feat-chat-read-receipts
branch
from
06dc2b7 to
449f003
Compare
brianp
requested review from
SWvheerden and
hansieodendaal
and removed request for
SWvheerden
SWvheerden
reviewed
Oct 3, 2023
SWvheerden
approved these changes
Oct 3, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves chat by moving chat message types that move over comms between peers into a specific chat wrapper type
ChatDispatch. This new type allows for multiple chat message forms such as a standard chat message, as well as read, and delivery confirmations.Motivation and Context
To enhance the chat FFI feature with check ✅, and double check ✅✅ capabilities such as chat apps like Telegram and WhatsApp. This PR features refactoring on the contacts service to support new message types, as well as FFI functionality to interact with the feature, including callbacks for receiving confirmations.
How Has This Been Tested?
Cucumber, CI.
What process can a PR reviewer use to test or verify this change?
Naming is questionable. But overall does the chat message wrapping fit our standard practice for similar concepts? The proto/prost enum support is unique and makes for some awkward
try_from's but it works well enough.Breaking Changes