feat: add overflow checks to change and fee calculations #5834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 23m 29s ⏱️ + 23m 29s For more details on these failures, see this check. Results for commit abdf660. ± Comparison against base commit 1d1332d. ♻️ This comment has been updated with latest results. |
brianp
approved these changes
Oct 10, 2023
base_layer/core/src/transactions/transaction_protocol/transaction_initializer.rs
Outdated
Show resolved
Hide resolved
ghpbot-tari-project
removed
the
P-reviews_required
AaronFeickert
requested changes
Oct 10, 2023
SWvheerden
reviewed
Oct 11, 2023
base_layer/core/src/transactions/transaction_protocol/transaction_initializer.rs
Outdated
Show resolved
Hide resolved
hansieodendaal
force-pushed
the
ho_fee_overflow
branch
from
d1a7416 to
663c40f
Compare
hansieodendaal
changed the title
AaronFeickert
previously approved these changes
Oct 11, 2023
|
ACK |
ghpbot-tari-project
removed
the
P-acks_required
SWvheerden
reviewed
Oct 12, 2023
hansieodendaal
force-pushed
the
ho_fee_overflow
branch
from
ab06732 to
0d77212
Compare
- Added overflow checks to sender transaction protocol. It is possible to crash the system in the change calculation before the transaction is validated; this PR prevents it. - Added an additinal unit test to verify three overflow errors are handled.
hansieodendaal
force-pushed
the
ho_fee_overflow
branch
from
0d77212 to
dd63e81
Compare
AaronFeickert
requested changes
Oct 12, 2023
SWvheerden
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fn test_sender_transaction_protocol_for_overflow) to verify three sender transaction protocol overflow errors are handled.fn test_fee_overflow) to verify the two fee overflow errors are handled.MinotariandMicroMinotaristring conversion issue (Minotari struct uses floating math in display #5839) for big numbers (with unit test) to allow for the proper error message to be printed in thefn test_fee_overflowunit test.Motivation and Context
It is possible to crash the system in the change calculation before the transaction is validated; this PR prevents it.
It is possible to crash the system with carefully crafted fees added to transactions and blocks; this PR prevents it.
How Has This Been Tested?
Added additional unit tests.
What process can a PR reviewer use to test or verify this change?
See unit tests and code changes.
Breaking Changes