feat(chatffi): get conversationalists #5849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
SWvheerden
reviewed
Oct 23, 2023
| /// ## Safety | ||
| /// The `ConversationalistsVector` should be destroyed after use | ||
| #[no_mangle] | ||
| pub unsafe extern "C" fn get_conversationalists( |
There was a problem hiding this comment.
I am missing the create and destroy test for this function in fn test_retrieving_conversationalists_from_vector
There was a problem hiding this comment.
The destroy is used in the test_retrieving_conversationalists_from_vector.
As for a get_conversationlists test it gets harder because it requires a whole running client/db/service etc. Which I haven't setup for any of the unit testing in chat. It is covered in cucumber though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a feature to fetch a list of TariAddresses that a client currently has conversations with. This is any address a message has been sent to or received from.
Motivation and Context
Without being about to fetch a list of addresses a client has conversations with, the client can't actually fetch any independent conversations, as conversations are fetched with an address id.
How Has This Been Tested?
New test additions
What process can a PR reviewer use to test or verify this change?
Changes are pretty standard throughout. Handler/Service/DB updates.
Breaking Changes