feat!: add validator mmr size #5873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
ghpbot-tari-project
removed
the
P-reviews_required
stringhandler
previously approved these changes
Nov 6, 2023
SWvheerden
force-pushed
the
sw_add_validator_mmr_size
branch
from
1736cc7 to
c59d54b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds in the size of the validator balance tree to the header.
Motivation and Context
The validator size needs to be committed too like the other Merkle roots as well. A peer syncing will have no way of verifying the validator merkle root is it does not know the size.
How Has This Been Tested?
Unit tests
What process can a PR reviewer use to test or verify this change?
ensure its committed to and not malleable.