feat: add config for grpc server methods #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
hansieodendaal
force-pushed
the
ho_disable_base_node_grpc
branch
from
3e0c548 to
bb610a7
Compare
sdbondi
reviewed
Oct 31, 2023
There was a problem hiding this comment.
Think the idea is solid, I looked at tonic interceptors and middleware and there will be a way to do it, however tonic makes it very difficult (unless I missed something obvious), so happy to add a conditional to the start of every method.
The implementation adds more maintenance overhead than required. I think adding a list of methods that should be denied will make things easier to maintain.
hansieodendaal
force-pushed
the
ho_disable_base_node_grpc
branch
from
bb610a7 to
c8270d7
Compare
Added configuration options for the base node's gRPC methods whereby each method can be enabled or disabled with the startup config settings.
hansieodendaal
force-pushed
the
ho_disable_base_node_grpc
branch
from
c8270d7 to
32ed96c
Compare
hansieodendaal
changed the title
SWvheerden
approved these changes
Nov 1, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added configuration options for the base node's gRPC methods whereby each method can be enabled or disabled with the startup-config settings.
Closing #5858
Some BloomRPC screenshots:
Motivation and Context
See #5858
How Has This Been Tested?
fn it_deserializes_enumsWhat process can a PR reviewer use to test or verify this change?
Breaking Changes