Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the windows installer auto build #5939

Merged

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Nov 10, 2023

Description

Fixed the Windows installer auto-build, renamed tari to minotari, updated build script to use an environment variable

Motivation and Context

Name change

How Has This Been Tested?

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link

github-actions bot commented Nov 10, 2023

Test Results (CI)

1 257 tests   1 257 ✔️  27m 11s ⏱️
     39 suites         0 💤
       1 files           0

Results for commit 0676acf.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 10, 2023
Copy link

github-actions bot commented Nov 10, 2023

Test Results (Integration tests)

31 tests   31 ✔️  15m 1s ⏱️
11 suites    0 💤
  2 files      0

Results for commit 0676acf.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think let's rather leave it as TariSuite, because people will download it from Tari.com

@leet4tari
Copy link
Contributor

LGMT - thanks!

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Nov 10, 2023
@SWvheerden SWvheerden merged commit a138b78 into tari-project:development Nov 10, 2023
14 checks passed
@hansieodendaal hansieodendaal deleted the ho_fix_windows_installer branch November 13, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants