feat: remove panics from applications #5943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
brianp
approved these changes
Nov 10, 2023
ghpbot-tari-project
removed
the
P-reviews_required
|
Yip, not my preferred choice, I prefer global panic. But it seems if its not the preferred approach. |
|
Maybe we'll have to investigate some kind of timed-out respawn of lost services |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applications currently panic on any thread panic. Remove this so that applications will not panic.
Motivation and Context
See: #5940
This is somewhat debatable if this is desired or not behaviour. But currently, the favoured approach is to only panic the thread.
Fixes: #5940