feat!: update status

[SWvheerden]

Description

Changes statuses of coinbase transactions and one-sided transactions

Motivation and Context

Transactions now show as one-sided or coinbase, not Faux anymore. This is more inline of what they are and shows more information to the user.

How Has This Been Tested?

manual + unit tests

Breaking Changes

Wallet database changes, and requires recovery to keep existing database.

[github-actions]

Test Results (Integration tests)

  2 files  +  2  12 suites  +12   1h 38m 38s ⏱️ + 1h 38m 38s
32 tests +32  27 ✔️ +27  0 💤 ±0    5 ❌ +  5 
42 runs  +42  27 ✔️ +27  0 💤 ±0  15 ❌ +15 

For more details on these failures, see this check.

Results for commit 7898aff. ± Comparison against base commit dee1892.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (CI)

1 260 tests   1 260 ✔️  10m 6s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 7898aff.

♻️ This comment has been updated with latest results.

[hansieodendaal]

Hi, some comments:

• The states a one-sided or coinbase scanned output goes through are exactly the same, and adding differentiation to statuses just adds complexity to the code.
• I think we should rather add an is_scanned column to the completed transactions (and potentially the outputs table as well) and track it that way - values could be 0 - not_scanned, 1 - one_sided and 2 - coinbase. (The outputs table already differentiates between the output types, but does not indicate if it was scanned or not.)
• When an output is imported or scanned, the is_scanned column can be populated based on the output features output type and associated script.

[SWvheerden]

I disagree with the is_scanned column. The current wallet design works with those statuses to indicate what it is, where it came from, and in what state it is. Adding a new separate enum to indicate the status add complexity.

[SWvheerden]

I have added a tech debt issue for addressing after this release: #6010

This is much more inline of what it should be. But its a much bigger refactor.

[hansieodendaal]

Wallet database changes, and requires recovery to keep existing database.

This is not strictly true, as only the statuses of old scanned coinbase transactions will be reported incorrectly.

[hansieodendaal]

ACK

(system-level tests performed)