Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix hazop findings #6017

Merged
merged 1 commit into from
Dec 6, 2023
Merged

feat: fix hazop findings #6017

merged 1 commit into from
Dec 6, 2023

Conversation

hansieodendaal
Copy link
Contributor

Description

Added some changes due to hazop findings. These include renaming for clarity, more accurate comments, and one improved database transaction for the blockchain backend to make removing headers atomic.

Motivation and Context

These changes were recommended as part of the ongoing hazop process.

How Has This Been Tested?

Existing tests pass

What process can a PR reviewer use to test or verify this change?

Code walk-through

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal
Fix hazop findings
6a9a218 
Added some changes due to hazop findings. These include renaming for clarity, more accurate comments,
and one improved database transaction for the blockchain backend to make removing headers atomic.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Test Results (CI)

1 260 tests   1 260 ✔️  12m 19s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 6a9a218.

@ghpbot-tari-project ghpbot-tari-project added P-reviews_required Process - Requires a review from a lead maintainer to be merged P-acks_required Process - Requires more ACKs or utACKs labels Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Test Results (Integration tests)

  2 files  +  2  12 suites  +12   1h 25m 12s ⏱️ + 1h 25m 12s
32 tests +32  26 ✔️ +26  0 💤 ±0    6 ❌ +  6 
43 runs  +43  28 ✔️ +28  0 💤 ±0  15 ❌ +15 

For more details on these failures, see this check.

Results for commit 6a9a218. ± Comparison against base commit cf66c51.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Dec 6, 2023
@SWvheerden SWvheerden merged commit 0bc62b4 into tari-project:development Dec 6, 2023
12 of 14 checks passed
@hansieodendaal hansieodendaal deleted the ho_hazop_findings branch January 10, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansieodendaal @SWvheerden @ghpbot-tari-project