feat: add tari address as valid string for discovering a peer #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)1 264 tests 1 264 ✅ 10m 17s ⏱️ Results for commit af1857a. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 12m 6s ⏱️ + 12m 6s For more details on these failures, see this check. Results for commit af1857a. ± Comparison against base commit c7d2d88. |
brianp
changed the title
SWvheerden
approved these changes
Jan 12, 2024
ghpbot-tari-project
removed
the
P-reviews_required
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 26, 2024
* development: (84 commits) chore: merge development to feature-dan2 (tari-project#6100) feat: prevent runtime error with compact error input (tari-project#6096) chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091) chore: update monero to latest release (tari-project#6098) chore(deps): bump actions/cache from 3 to 4 (tari-project#6093) chore(fix): ci - move s3 uploads to only on release (tari-project#6094) feat: update codeowners (tari-project#6088) chore: update change log (tari-project#6086) feat: add search kernels method to nodejs client (tari-project#6082) chore: move domain hash names to separate crate (tari-project#6076) chore: new esme release (tari-project#6084) fix: tms validation correctly updating (tari-project#6079) fix: wallet coinbases not validated correctly (tari-project#6074) chore(fix): ci - ffis android - add protobuf for cross-compile (tari-project#6083) chore(fix): include protobuf during build (tari-project#6077) chore: upgrade tonic and prost (tari-project#6067) feat: add tari address as valid string for discovering a peer (tari-project#6075) docs: update disclosure policy (tari-project#6072) chore(ci): ffi extend to build for none mobile platforms (tari-project#6069) refactor(common): allow custom default configs (tari-project#6068) ...
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 26, 2024
* development: (85 commits) revert: merge development to feature-dan2 (tari-project#6100) (tari-project#6102) chore: merge development to feature-dan2 (tari-project#6100) feat: prevent runtime error with compact error input (tari-project#6096) chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091) chore: update monero to latest release (tari-project#6098) chore(deps): bump actions/cache from 3 to 4 (tari-project#6093) chore(fix): ci - move s3 uploads to only on release (tari-project#6094) feat: update codeowners (tari-project#6088) chore: update change log (tari-project#6086) feat: add search kernels method to nodejs client (tari-project#6082) chore: move domain hash names to separate crate (tari-project#6076) chore: new esme release (tari-project#6084) fix: tms validation correctly updating (tari-project#6079) fix: wallet coinbases not validated correctly (tari-project#6074) chore(fix): ci - ffis android - add protobuf for cross-compile (tari-project#6083) chore(fix): include protobuf during build (tari-project#6077) chore: upgrade tonic and prost (tari-project#6067) feat: add tari address as valid string for discovering a peer (tari-project#6075) docs: update disclosure policy (tari-project#6072) chore(ci): ffi extend to build for none mobile platforms (tari-project#6069) ...
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jan 26, 2024
* development: (85 commits) revert: merge development to feature-dan2 (tari-project#6100) (tari-project#6102) chore: merge development to feature-dan2 (tari-project#6100) feat: prevent runtime error with compact error input (tari-project#6096) chore(deps): bump h2 from 0.3.21 to 0.3.24 (tari-project#6091) chore: update monero to latest release (tari-project#6098) chore(deps): bump actions/cache from 3 to 4 (tari-project#6093) chore(fix): ci - move s3 uploads to only on release (tari-project#6094) feat: update codeowners (tari-project#6088) chore: update change log (tari-project#6086) feat: add search kernels method to nodejs client (tari-project#6082) chore: move domain hash names to separate crate (tari-project#6076) chore: new esme release (tari-project#6084) fix: tms validation correctly updating (tari-project#6079) fix: wallet coinbases not validated correctly (tari-project#6074) chore(fix): ci - ffis android - add protobuf for cross-compile (tari-project#6083) chore(fix): include protobuf during build (tari-project#6077) chore: upgrade tonic and prost (tari-project#6067) feat: add tari address as valid string for discovering a peer (tari-project#6075) docs: update disclosure policy (tari-project#6072) chore(ci): ffi extend to build for none mobile platforms (tari-project#6069) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the use of a TariAddress as well as public key or node id when discovering new peers in the wallet or base node.
Motivation and Context
Easier to manage expectations. When selecting your wallet address it's shows as a TariAddress, so someone needs to be able to do something with that.
How Has This Been Tested?
locally
Breaking Changes