feat: update api #6101
Merged
feat: update api #6101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update grpc network call
Test Results (CI)1 264 tests 1 264 ✅ 11m 33s ⏱️ Results for commit b7bb190. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 14m 4s ⏱️ For more details on these failures, see this check. Results for commit b7bb190. ♻️ This comment has been updated with latest results. |
| /// # Safety | ||
| /// The ```string_destroy``` method must be called when finished with a string from rust to prevent a memory leak | ||
| #[no_mangle] | ||
| pub unsafe extern "C" fn tari_address_network(address: *mut TariWalletAddress, error_out: *mut c_int) -> *mut c_char { |
There was a problem hiding this comment.
We probably need to include this method in a unit test
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add FFI call to get the network of a TariAdress
Add Tari Unique ID for merge mining to mining calls
Motivation and Context
Small improvements to tari's outside API calls.