Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial horizon sync from prune node #6109

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Jan 30, 2024

Description

  • Implemented initial horizon sync from prune node.
  • Added an integration-level unit test to ensure it works as intended.

Motivation and Context

This will be more efficient for the network in total

How Has This Been Tested?

New integration-level unit test
System-level sync tests from archival node and from prune node

What process can a PR reviewer use to test or verify this change?

See integration-level unit test
Perform system-level sync test

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal requested a review from a team as a code owner January 30, 2024 07:15
@ghpbot-tari-project ghpbot-tari-project added the CR-too_long Changes Requested - Your PR is too long label Jan 30, 2024
@hansieodendaal hansieodendaal marked this pull request as draft January 30, 2024 07:15
Copy link

github-actions bot commented Jan 30, 2024

Test Results (CI)

1 269 tests   1 269 ✅  12m 1s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit c37620c.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jan 30, 2024
Copy link

github-actions bot commented Jan 30, 2024

Test Results (Integration tests)

 2 files  11 suites   29m 50s ⏱️
29 tests 28 ✅ 0 💤 1 ❌
31 runs  29 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit c37620c.

♻️ This comment has been updated with latest results.

@hansieodendaal hansieodendaal force-pushed the ho_horizon_sync_from_prune_node branch 10 times, most recently from 89fe96a to 68e14d3 Compare February 1, 2024 09:49
@hansieodendaal hansieodendaal force-pushed the ho_horizon_sync_from_prune_node branch from 68e14d3 to c37620c Compare February 1, 2024 12:14
@hansieodendaal hansieodendaal marked this pull request as ready for review February 1, 2024 12:15
@hansieodendaal hansieodendaal changed the title !feat: initial horizon sync from prune node feat: initial horizon sync from prune node Feb 1, 2024
@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Feb 2, 2024
@SWvheerden SWvheerden merged commit 2987621 into tari-project:development Feb 2, 2024
13 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_horizon_sync_from_prune_node branch March 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-too_long Changes Requested - Your PR is too long P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants