feat: check chain metadata #6146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)1 270 tests 1 270 ✅ 10m 55s ⏱️ Results for commit 74f03e8. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)29 tests 29 ✅ 12m 24s ⏱️ Results for commit 74f03e8. |
ghpbot-tari-project
removed
the
P-reviews_required
Comment on lines
+75
to
+77
| if chain_meta_data.accumulated_difficulty == 0.into() { | ||
| return Err(ChainMetaDataError::AccumulatedDifficultyZero); | ||
| }; |
There was a problem hiding this comment.
We could check U256::MAX as well?
There was a problem hiding this comment.
what do you want to check, u256::max is a valid difficulty, 0 is not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks chain metadata for correctness
Motivation and Context
The base node makes certain logic desisions based on what the chain meta data is, but no where do we make checks to ensure that the data is valid inside of this.
How Has This Been Tested?
unit tests