Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: horizon sync #6197

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: horizon sync #6197

merged 1 commit into from
Mar 11, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Fixes horizon sync

Motivation and Context

Burned outputs are counted as spent, so we should not sync them when doing horizon sync.

How Has This Been Tested?

manual

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@SWvheerden SWvheerden requested a review from a team as a code owner March 11, 2024 05:52
@github-actions GitHub Actions
Copy link

Test Results (CI)

    3 files    120 suites   38m 10s ⏱️
1 268 tests 1 268 ✅ 0 💤 0 ❌
3 796 runs  3 796 ✅ 0 💤 0 ❌

Results for commit 0fd3e32.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Mar 11, 2024
@github-actions GitHub Actions
Copy link

Test Results (Integration tests)

29 tests  +29   29 ✅ +29   11m 57s ⏱️ + 11m 57s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 0fd3e32. ± Comparison against base commit 4821660.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Mar 11, 2024
@SWvheerden SWvheerden merged commit c96be82 into tari-project:development Mar 11, 2024
15 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_fix_horizon_sync branch March 11, 2024 08:32
hansieodendaal
hansieodendaal reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal left review comments

@brianp brianp brianp approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SWvheerden @brianp @hansieodendaal @ghpbot-tari-project