fix: improve wallet connection response time #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
changed the title
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 120 suites 35m 11s ⏱️ Results for commit 95140ed. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files + 2 11 suites +11 53m 30s ⏱️ + 53m 30s For more details on these failures, see this check. Results for commit 95140ed. ± Comparison against base commit 60bd218. |
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the time a wallet will detect that the base node its connecting to is up and running
Motivation and Context
The time between tries here was 3 secs previously, but an unrelated change to the reuse of time variables bumped this up to 90 secs. This means that even thou the wallet is technically connected to the base node, the wallet service will wait for up to 90 secs before confirm this is the case. This bumps it down to 5 secs.
How Has This Been Tested?
Manual