fix(comms/core): upgrade to yamux 0.13 #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 37m 17s ⏱️ Results for commit 0a2aaf7. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 14m 4s ⏱️ + 14m 4s For more details on these failures, see this check. Results for commit 0a2aaf7. ± Comparison against base commit 925d29a. ♻️ This comment has been updated with latest results. |
SWvheerden
previously approved these changes
May 3, 2024
ghpbot-tari-project
removed
the
P-reviews_required
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates yamux to 0.13.2 from 0.10.2
Refactor RPC tests to account for internal changes in yamux
Motivation and Context
Includes improvements in yamux since 0.10. Including libp2p/rust-yamux@460baf2
One major difference is that the substream is not opened until the client sends a message. This only affects some tests written in a "weird" way where the outbound stream was notified as an inbound substream and the inbound stream is written to first. In all real usages of substreams, the outbound stream always writes first.
This has been tested on the existing nextnet network for breaking changes and there were no issues detected.
How Has This Been Tested?
Existing tests updated, manually syncing nextnet (non-breaking change test) and wallet
Localnet manual test with 2 base nodes and 1 wallet
What process can a PR reviewer use to test or verify this change?
All applications should work as before
Breaking Changes