feat: split message to have dedicated to and from fields #6358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 56m 20s ⏱️ Results for commit 64cbdc9. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 40m 24s ⏱️ For more details on these failures, see this check. Results for commit 64cbdc9. ♻️ This comment has been updated with latest results. |
brianp
reviewed
May 27, 2024
base_layer/contacts/src/contacts_service/storage/types/messages.rs
Outdated
Show resolved
Hide resolved
ghpbot-tari-project
removed
the
P-reviews_required
make dual addresses fmt build
SWvheerden
force-pushed
the
sw_to_from_addresses
branch
from
03f5e90 to
ca420a8
Compare
ghpbot-tari-project
added
the
P-reviews_required
base_layer/contacts/migrations/2024-05-27-145200_add_from_to_fields/up.sql
Outdated
Show resolved
Hide resolved
Comment on lines
43
to
44
| pub to_address: Vec<u8>, | ||
| pub from_address: Vec<u8>, |
There was a problem hiding this comment.
ditto receiver & sender
Comment on lines
57
to
58
| pub to_address: Vec<u8>, | ||
| pub from_address: Vec<u8>, |
There was a problem hiding this comment.
ditto receiver & sender
Comment on lines
167
to
170
| let to_address = | ||
| TariAddress::from_bytes(&o.to_address).map_err(|_| ContactsServiceStorageError::ConversionError)?; | ||
| let from_address = | ||
| TariAddress::from_bytes(&o.from_address).map_err(|_| ContactsServiceStorageError::ConversionError)?; |
There was a problem hiding this comment.
ditto receiver & sender
Comment on lines
202
to
203
| to_address: o.to_address.to_bytes().to_vec(), | ||
| from_address: o.from_address.to_bytes().to_vec(), |
There was a problem hiding this comment.
ditto receiver & sender
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
split message to have dedicated to and from fields
Motivation and Context
This is needed for #6353
When a chat client receives a message, it needs to know the complete address of the receiver, not just a part of it. This allows the user to get the complete address by saving what the sender said their address is