feat: remove ablity to send 1-sided tx #6367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 44m 37s ⏱️ Results for commit e22dfca. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 1 errors 9 suites +9 12m 8s ⏱️ + 12m 8s For more details on these parsing errors and failures, see this check. Results for commit e22dfca. ± Comparison against base commit 97b5128. ♻️ This comment has been updated with latest results. |
SWvheerden
force-pushed
the
removeCW1-sidesend
branch
from
c2fdb6c to
95218cb
Compare
|
I want to keep that in for now, until we know exactly how we want to work with exchanges, they want want to use it. So for now I am only removing the front end calling |
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
force-pushed
the
removeCW1-sidesend
branch
from
95218cb to
a13f3f0
Compare
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the ability to send one-sided transactions from the CW, preferring to only send stealth one-sided
Motivation and Context
There is no benefit for sending normal one-sided, only negatives in regard to privacy