Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check address features on send #6433

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Add checking of addresses on send

Motivation and Context

We should not send a transaction to an address not accepting that feature. This will check the network and if the address accepts interactive/one-sided

@SWvheerden SWvheerden requested a review from a team as a code owner July 26, 2024 14:00
Copy link

github-actions bot commented Jul 26, 2024

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   24m 58s ⏱️ + 24m 58s
35 tests +35  34 ✅ +34  0 💤 ±0  1 ❌ +1 
36 runs  +36  35 ✅ +35  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 7d951e6. ± Comparison against base commit 3377e9c.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Test Results (CI)

    3 files    123 suites   35m 4s ⏱️
1 298 tests 1 298 ✅ 0 💤 0 ❌
3 886 runs  3 886 ✅ 0 💤 0 ❌

Results for commit 7d951e6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@SWvheerden SWvheerden merged commit 2f491fa into tari-project:development Aug 1, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_add_tx_checking branch August 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants