Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: console wallet recovery improvements for ledger #6455

Merged

Conversation

brianp
Copy link
Contributor

@brianp brianp commented Aug 6, 2024

Description

When creating a ledger-based wallet don't show recovery seed words, as they're not used to recover the ledger wallet type.
Additionally don't request recovery seed words for recovery, when recovering a ledger based wallet.

Motivation and Context

It can be confusing as the seed words between the hardware device and the software wallet won't actually align. In the event of hardware wallet the software seed phrase can be ignored, and generated randomly upon recovery. Only the ledger hardware recovery is important and that's managed outside of the software wallet.

How Has This Been Tested?

Manually

What process can a PR reviewer use to test or verify this change?

Create a wallet
Recover a wallet

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link

github-actions bot commented Aug 6, 2024

Test Results (CI)

    3 files    123 suites   36m 49s ⏱️
1 300 tests 1 300 ✅ 0 💤 0 ❌
3 892 runs  3 892 ✅ 0 💤 0 ❌

Results for commit e739ac3.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Test Results (Integration tests)

 2 files   1 errors  9 suites   13m 47s ⏱️
19 tests 17 ✅ 0 💤 2 ❌
21 runs  19 ✅ 0 💤 2 ❌

For more details on these parsing errors and failures, see this check.

Results for commit e739ac3.

@SWvheerden SWvheerden merged commit e726e5d into tari-project:development Aug 6, 2024
15 of 17 checks passed
@brianp brianp deleted the bp-feat-recovery-phrase branch August 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants