fix: wallet validation #6468
Merged
fix: wallet validation #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improvments on validation imporovements on UI feedback
Test Results (CI) 3 files 126 suites 39m 46s ⏱️ For more details on these failures, see this check. Results for commit 20fbdd8. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 42m 45s ⏱️ + 42m 45s For more details on these failures, see this check. Results for commit c9340d8. ± Comparison against base commit 131225c. ♻️ This comment has been updated with latest results. |
|
yes I can see that, busy looking into it |
hansieodendaal
previously approved these changes
Aug 15, 2024
| @@ -40,7 +40,7 @@ pub struct BaseNodeServiceConfig { | |||
| impl Default for BaseNodeServiceConfig { | |||
| fn default() -> Self { | |||
| Self { | |||
| base_node_monitor_max_refresh_interval: Duration::from_secs(90), | |||
| base_node_monitor_max_refresh_interval: Duration::from_secs(30), | |||
There was a problem hiding this comment.
We need to update the default value in the corresponding config.toml file as well
| @@ -157,7 +157,7 @@ event_channel_size = 3500 | |||
| [wallet.base_node] | |||
| # Configuration for the wallet's base node service | |||
| # The refresh interval (default = 3 s) | |||
There was a problem hiding this comment.
Suggested change
| # The refresh interval (default = 3 s) | |
| # The refresh interval (default = 30 s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed small bugs in validation
Fixed small bugs in wallet display of coinbases and one-sided payments