Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backup spend #6495

Merged
merged 3 commits into from
Aug 21, 2024
Merged

fix: backup spend #6495

merged 3 commits into from
Aug 21, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

fixes pre mine backup spend

@SWvheerden SWvheerden requested a review from a team as a code owner August 21, 2024 13:47
@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Aug 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

Test Results (CI)

    3 files    126 suites   35m 18s ⏱️
1 306 tests 1 306 ✅ 0 💤 0 ❌
3 904 runs  3 904 ✅ 0 💤 0 ❌

Results for commit 51f8bd2.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 21, 2024
hansieodendaal
hansieodendaal reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

base_layer/wallet/src/output_manager_service/service.rs Show resolved Hide resolved
base_layer/wallet/src/output_manager_service/service.rs Show resolved Hide resolved
base_layer/wallet/src/output_manager_service/service.rs Show resolved Hide resolved
base_layer/wallet/src/output_manager_service/service.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/output_manager_service/service.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Test Results (Integration tests)

37 tests   37 ✅  17m 7s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit 51f8bd2.

@SWvheerden SWvheerden merged commit 13b34d1 into tari-project:development Aug 21, 2024
16 of 17 checks passed
@SWvheerden SWvheerden deleted the sw_fix_backUp_spend branch August 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal left review comments

Assignees
No one assigned
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project