Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minotari node): add get_sync_progress to allow list if mining is enabled #6498

Conversation

MCozhusheck
Copy link
Contributor

Description

Allows to call GetSyncProgress if node is in mining node.

Motivation and Context

Tari Universe V1 needs to know what's the progress of node sync to display it to the user. Right now it's not possible as nodes refuses to response GetSyncProgress call and manually adding this through CLI throws exit code 101 (invalid config).

How Has This Been Tested?

Run command cargo test

What process can a PR reviewer use to test or verify this change?

Same as above

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@MCozhusheck MCozhusheck changed the title fix:add GetSyncProgress to allow list if mining is enabled fix(minotari node):add GetSyncProgress to allow list if mining is enabled Aug 22, 2024
@ghpbot-tari-project ghpbot-tari-project added the P-acks_required Process - Requires more ACKs or utACKs label Aug 22, 2024
@MCozhusheck MCozhusheck marked this pull request as ready for review August 22, 2024 08:07
Copy link

Test Results (CI)

    3 files    126 suites   38m 12s ⏱️
1 300 tests 1 299 ✅ 0 💤 1 ❌
3 898 runs  3 897 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit fed88cf.

Copy link

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   34m 29s ⏱️ + 34m 29s
37 tests +37  35 ✅ +35  0 💤 ±0  2 ❌ +2 
40 runs  +40  37 ✅ +37  0 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit fed88cf. ± Comparison against base commit a510455.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@hansieodendaal hansieodendaal changed the title fix(minotari node):add GetSyncProgress to allow list if mining is enabled fix(minotari node): add get_sync_progress to allow list if mining is enabled Aug 26, 2024
@SWvheerden SWvheerden merged commit e9c420d into tari-project:development Aug 26, 2024
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants