Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop interactive only address from being used in mining #6544

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Block use of interactive only address from being used in coinbase builder

@SWvheerden SWvheerden requested a review from a team as a code owner September 9, 2024 13:52
@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Test Results (CI)

    3 files    129 suites   41m 36s ⏱️
1 308 tests 1 307 ✅ 0 💤 1 ❌
3 922 runs  3 921 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 97e85fa.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Test Results (Integration tests)

36 tests   36 ✅  14m 48s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit 97e85fa.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 10, 2024
@SWvheerden SWvheerden merged commit 1f18e7d into tari-project:development Sep 10, 2024
16 of 17 checks passed
@SWvheerden SWvheerden deleted the sw_check_coinbase_build branch September 10, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants