Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: view wallet key usage #6575

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

fix view wallet key usage

Motivation and Context

View wallet should not try and derive its keys, but rather just return them.

fix view wallet key usage
@SWvheerden SWvheerden requested a review from a team as a code owner September 23, 2024 11:21
Copy link

github-actions bot commented Sep 23, 2024

Test Results (CI)

    3 files    129 suites   38m 17s ⏱️
1 322 tests 1 321 ✅ 0 💤 1 ❌
3 965 runs  3 964 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit ca68b89.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Sep 23, 2024
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it's working great

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Sep 23, 2024
Copy link

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   29m 8s ⏱️ + 29m 8s
36 tests +36  35 ✅ +35  0 💤 ±0  1 ❌ +1 
37 runs  +37  36 ✅ +36  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit ca68b89. ± Comparison against base commit bb7f128.

@SWvheerden SWvheerden merged commit 88b242d into tari-project:development Sep 23, 2024
15 of 17 checks passed
SWvheerden added a commit to SWvheerden/tari that referenced this pull request Sep 23, 2024
Description
---
fix view wallet key usage

Motivation and Context
---
View wallet should not try and derive its keys, but rather just return
them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants