fix(comms): ensure that inbound messaging terminates on disconnect #6653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 129 suites 39m 28s ⏱️ Results for commit 6629a26. |
Test Results (Integration tests) 2 files + 2 11 suites +11 23m 25s ⏱️ + 23m 25s For more details on these failures, see this check. Results for commit 6629a26. ± Comparison against base commit f802743. |
SWvheerden
approved these changes
Oct 29, 2024
|
Nice one |
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 30, 2024
* development: fix(comms): ensure that inbound messaging terminates on disconnect (tari-project#6653) chore(deps): bump azure/trusted-signing-action from 0.4.0 to 0.5.0 (tari-project#6652) chore: new release esme v1.8.0-pre.0 (tari-project#6651) feat: close rpc connections when not in use - without close on dial requests (tari-project#6649) Update README.md with correct discord link (tari-project#6650) chore: new release esmeralda (tari-project#6647) chore: release new esmeralda v1.7.0-pre.3 (tari-project#6642)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(comms): ensure that inbound messaging terminates on disconnect
Motivation and Context
Ensure that the inbound messaging worker terminates when the peer connection is disconnected.
This PR ensures this by using the
PeerConnection::on_disconnectfuture. It has not been confirmedthat the inbound worker would not terminate before however this PR will guarantee it.
How Has This Been Tested?
Updated unit tests.
What process can a PR reviewer use to test or verify this change?
Breaking Changes