feat(queue-events): add QueueEventsProducer for publishing custom events #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Oct 21, 2024
src/classes/queue-events.ts
Outdated
| @@ -307,7 +316,8 @@ export class QueueEvents extends QueueBase { | |||
| this.emit(event, id); | |||
| } else { | |||
| this.emit(event as any, restArgs, id); | |||
| this.emit(`${event}:${restArgs.jobId}` as any, restArgs, id); | |||
| if (restArgs.jobId) | |||
| {this.emit(`${event}:${restArgs.jobId}` as any, restArgs, id);} | |||
There was a problem hiding this comment.
the code format here looks strange
There was a problem hiding this comment.
yeah for some reason, lint didn't get applied
roggervalf
force-pushed
the
feat-custom-events
branch
4 times, most recently
from
03f409b to
5cab36e
Compare
|
Very cool, subscribed to this one for when it drops. Did a similar setup to the "steps" pattern in the docs but without an event for the step changes, it's a bit clunky at parts. thanks for this. |
roggervalf
force-pushed
the
feat-custom-events
branch
from
5cab36e to
c12d93e
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
# [5.25.0](v5.24.0...v5.25.0) (2024-11-06) ### Features * **queue-events:** add QueueEventsProducer for publishing custom events ([#2844](#2844)) ([5eb03cd](5eb03cd))
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Nov 6, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.23.1` -> `5.25.0`](https://renovatebot.com/diffs/npm/bullmq/5.23.1/5.25.0) | --- ### Release Notes <details> <summary>taskforcesh/bullmq (bullmq)</summary> ### [`v5.25.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.25.0) [Compare Source](taskforcesh/bullmq@v5.24.0...v5.25.0) ##### Features - **queue-events:** add QueueEventsProducer for publishing custom events ([#​2844](taskforcesh/bullmq#2844)) ([5eb03cd](taskforcesh/bullmq@5eb03cd)) ### [`v5.24.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.24.0) [Compare Source](taskforcesh/bullmq@v5.23.1...v5.24.0) ##### Features - **flows:** add telemetry support ([#​2879](taskforcesh/bullmq#2879)) ([5ed154b](taskforcesh/bullmq@5ed154b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/298 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation is missing
ref #2759