Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(marker): add base markers while consuming jobs to get workers busy #2904

Merged
merged 1 commit into from
Nov 19, 2024
Merged

perf(marker): add base markers while consuming jobs to get workers busy #2904

merged 1 commit into from
Nov 19, 2024

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Nov 14, 2024 •
edited
Loading

fixes #2842

manast
manast reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to look good but I think we need to make a stress test to see if it works as intended.

@roggervalf roggervalf force-pushed the perf-multiple-markers-v2 branch from cd78d98 to d6599f3 Compare November 14, 2024 14:31
@roggervalf roggervalf force-pushed the perf-multiple-markers-v2 branch from d6599f3 to 0e1ad44 Compare November 19, 2024 02:57
@roggervalf roggervalf mentioned this pull request Nov 19, 2024
Closed
@roggervalf roggervalf merged commit 1759c8b into master Nov 19, 2024
12 checks passed
@roggervalf roggervalf deleted the perf-multiple-markers-v2 branch November 19, 2024 03:12
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@semantic-release-bot
chore(release): 5.27.0 [skip ci]
2129569 
# [5.27.0](v5.26.2...v5.27.0) (2024-11-19)

### Features

* **queue:** add rateLimit method ([#2896](#2896)) ([db84ad5](db84ad5))
* **queue:** add removeRateLimitKey method ([#2806](#2806)) ([ff70613](ff70613))

### Performance Improvements

* **marker:** add base markers while consuming jobs to get workers busy ([#2904](#2904)) fixes [#2842](#2842) ([1759c8b](1759c8b))
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Nov 27, 2024
@alexandresoro
fix(deps): update dependency bullmq to v5.29.1 (#340)
c156beb 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.25.6` -> `5.29.1`](https://renovatebot.com/diffs/npm/bullmq/5.25.6/5.29.1) |

---

### Release Notes

<details>
<summary>taskforcesh/bullmq (bullmq)</summary>

### [`v5.29.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.29.1)

[Compare Source](taskforcesh/bullmq@v5.29.0...v5.29.1)

##### Bug Fixes

-   **scheduler:** remove deprecation warning on immediately option ([#&#8203;2923](taskforcesh/bullmq#2923)) ([14ca7f4](taskforcesh/bullmq@14ca7f4))

### [`v5.29.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.29.0)

[Compare Source](taskforcesh/bullmq@v5.28.2...v5.29.0)

##### Features

-   **queue:** refactor a protected addJob method allowing telemetry extensions ([09f2571](taskforcesh/bullmq@09f2571))

### [`v5.28.2`](https://github.com/taskforcesh/bullmq/releases/tag/v5.28.2)

[Compare Source](taskforcesh/bullmq@v5.28.1...v5.28.2)

##### Bug Fixes

-   **queue:** change \_jobScheduler from private to protected for extension ([#&#8203;2920](taskforcesh/bullmq#2920)) ([34c2348](taskforcesh/bullmq@34c2348))

### [`v5.28.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.28.1)

[Compare Source](taskforcesh/bullmq@v5.28.0...v5.28.1)

##### Bug Fixes

-   **scheduler:** use Job class from getter for extension ([#&#8203;2917](taskforcesh/bullmq#2917)) ([5fbb075](taskforcesh/bullmq@5fbb075))

### [`v5.28.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.28.0)

[Compare Source](taskforcesh/bullmq@v5.27.0...v5.28.0)

##### Features

-   **job-scheduler:** add telemetry support to the job scheduler ([72ea950](taskforcesh/bullmq@72ea950))

### [`v5.27.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.27.0)

[Compare Source](taskforcesh/bullmq@v5.26.2...v5.27.0)

##### Features

-   **queue:** add rateLimit method ([#&#8203;2896](taskforcesh/bullmq#2896)) ([db84ad5](taskforcesh/bullmq@db84ad5))
-   **queue:** add removeRateLimitKey method ([#&#8203;2806](taskforcesh/bullmq#2806)) ([ff70613](taskforcesh/bullmq@ff70613))

##### Performance Improvements

-   **marker:** add base markers while consuming jobs to get workers busy ([#&#8203;2904](taskforcesh/bullmq#2904)) fixes [#&#8203;2842](taskforcesh/bullmq#2842) ([1759c8b](taskforcesh/bullmq@1759c8b))

### [`v5.26.2`](https://github.com/taskforcesh/bullmq/releases/tag/v5.26.2)

[Compare Source](taskforcesh/bullmq@v5.26.1...v5.26.2)

##### Bug Fixes

-   **telemetry:** do not set span on parent context if undefined ([c417a23](taskforcesh/bullmq@c417a23))

### [`v5.26.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.26.1)

[Compare Source](taskforcesh/bullmq@v5.26.0...v5.26.1)

##### Bug Fixes

-   **queue:** fix generics to be able to properly be extended ([f2495e5](taskforcesh/bullmq@f2495e5))

### [`v5.26.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.26.0)

[Compare Source](taskforcesh/bullmq@v5.25.6...v5.26.0)

##### Features

-   improve queue getters to use generic job type ([#&#8203;2905](taskforcesh/bullmq#2905)) ([c9531ec](taskforcesh/bullmq@c9531ec))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/340
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manast manast manast left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Uneven job distribution between workers
2 participants
@roggervalf @manast