feat: improve queue getters to use generic job type #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/improve-queue-getters-generics-for-extension
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
# [5.26.0](v5.25.6...v5.26.0) (2024-11-14) ### Features * improve queue getters to use generic job type ([#2905](#2905)) ([c9531ec](c9531ec))
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Nov 27, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.25.6` -> `5.29.1`](https://renovatebot.com/diffs/npm/bullmq/5.25.6/5.29.1) | --- ### Release Notes <details> <summary>taskforcesh/bullmq (bullmq)</summary> ### [`v5.29.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.29.1) [Compare Source](taskforcesh/bullmq@v5.29.0...v5.29.1) ##### Bug Fixes - **scheduler:** remove deprecation warning on immediately option ([#​2923](taskforcesh/bullmq#2923)) ([14ca7f4](taskforcesh/bullmq@14ca7f4)) ### [`v5.29.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.29.0) [Compare Source](taskforcesh/bullmq@v5.28.2...v5.29.0) ##### Features - **queue:** refactor a protected addJob method allowing telemetry extensions ([09f2571](taskforcesh/bullmq@09f2571)) ### [`v5.28.2`](https://github.com/taskforcesh/bullmq/releases/tag/v5.28.2) [Compare Source](taskforcesh/bullmq@v5.28.1...v5.28.2) ##### Bug Fixes - **queue:** change \_jobScheduler from private to protected for extension ([#​2920](taskforcesh/bullmq#2920)) ([34c2348](taskforcesh/bullmq@34c2348)) ### [`v5.28.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.28.1) [Compare Source](taskforcesh/bullmq@v5.28.0...v5.28.1) ##### Bug Fixes - **scheduler:** use Job class from getter for extension ([#​2917](taskforcesh/bullmq#2917)) ([5fbb075](taskforcesh/bullmq@5fbb075)) ### [`v5.28.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.28.0) [Compare Source](taskforcesh/bullmq@v5.27.0...v5.28.0) ##### Features - **job-scheduler:** add telemetry support to the job scheduler ([72ea950](taskforcesh/bullmq@72ea950)) ### [`v5.27.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.27.0) [Compare Source](taskforcesh/bullmq@v5.26.2...v5.27.0) ##### Features - **queue:** add rateLimit method ([#​2896](taskforcesh/bullmq#2896)) ([db84ad5](taskforcesh/bullmq@db84ad5)) - **queue:** add removeRateLimitKey method ([#​2806](taskforcesh/bullmq#2806)) ([ff70613](taskforcesh/bullmq@ff70613)) ##### Performance Improvements - **marker:** add base markers while consuming jobs to get workers busy ([#​2904](taskforcesh/bullmq#2904)) fixes [#​2842](taskforcesh/bullmq#2842) ([1759c8b](taskforcesh/bullmq@1759c8b)) ### [`v5.26.2`](https://github.com/taskforcesh/bullmq/releases/tag/v5.26.2) [Compare Source](taskforcesh/bullmq@v5.26.1...v5.26.2) ##### Bug Fixes - **telemetry:** do not set span on parent context if undefined ([c417a23](taskforcesh/bullmq@c417a23)) ### [`v5.26.1`](https://github.com/taskforcesh/bullmq/releases/tag/v5.26.1) [Compare Source](taskforcesh/bullmq@v5.26.0...v5.26.1) ##### Bug Fixes - **queue:** fix generics to be able to properly be extended ([f2495e5](taskforcesh/bullmq@f2495e5)) ### [`v5.26.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.26.0) [Compare Source](taskforcesh/bullmq@v5.25.6...v5.26.0) ##### Features - improve queue getters to use generic job type ([#​2905](taskforcesh/bullmq#2905)) ([c9531ec](taskforcesh/bullmq@c9531ec)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/340 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue we have in BullMQ Pro, where the queue getters do not return jobs of type JobPro. The solution is to use a generic for the Job type, and define that type when subclassing QueueGetters.