Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterator Record [[NextMethod]] type incorrect #3033

Closed
michaelficarra opened this issue Mar 30, 2023 · 1 comment · Fixed by #3067
Closed

Iterator Record [[NextMethod]] type incorrect #3033

michaelficarra opened this issue Mar 30, 2023 · 1 comment · Fixed by #3067
Labels
spec bug

Comments

@michaelficarra
Copy link
Member

The type of the [[NextMethod]] field of Iterator Records is declared to be "a function object", but in GetIterator, ForIn/OfHeadEvaluation, and CreateAsyncFromSyncIterator, we stick the result of Get(iterator, "next") directly into there without validating it. We should either update the type or check/throw before constructing the Iterator Record (this seems to require impossible normative changes).
@michaelficarra michaelficarra mentioned this issue Mar 30, 2023
Merged
@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Mar 30, 2023
@michaelficarra michaelficarra mentioned this issue Mar 30, 2023
Merged
@michaelficarra
Copy link
Member Author

The proposed normative change is a duplicate of #2903 and being considered at the next plenary.

@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Apr 5, 2023
This was referenced May 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: fix the type of Iterator Record [[NextMethod]] tc39/ecma262
1 participant
@michaelficarra