Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric type of Intl.DateTimeFormat [[FractionalSecondDigits]] #725

Closed
ptomato opened this issue Nov 2, 2022 · 3 comments
Closed

Numeric type of Intl.DateTimeFormat [[FractionalSecondDigits]] #725

ptomato opened this issue Nov 2, 2022 · 3 comments

Comments

@ptomato
Copy link
Contributor

ptomato commented Nov 2, 2022

(Follow up from #715 (comment))

There is an inconsistency about whether [[FractionalSecondDigits]] contains a Number or mathematical value. Properties of Intl.DateTimeFormat instances says either undefined or a "positive non-zero integer Number value" but step 36.d of InitializeDateTimeFormat arguably stores a mathematical value (returned from GetNumberOption in step 36.b.i) in the slot. In FormatDateTimePattern the value is passed to CreateDataPropertyOrThrow in step 12.b which suggests a Number value, but in 15.c.ii it's used in a mixed mathematical/Number value calculation which is an editorial error.

(I say "arguably stores a mathematical value" because GetNumberOption/DefaultNumberOption return a Number value, but it is compared against mathematical values minimum and maximum, and the operation floor() is applied to it, all of which are only valid for mathematical values.)

@gibson042
Copy link
Contributor

Reated: #648

@anba
Copy link
Contributor

anba commented Aug 14, 2023

#822 should fix this issue.

@sffc
Copy link
Contributor

sffc commented Dec 14, 2023

#822 is merged so I assume this issue is fixed. If it is not fixed, please re-open.

@sffc sffc closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants