Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more calendar: 'gregory' coverage to Test262 tests and/or demitasse tests #1776

Closed
justingrant opened this issue Aug 25, 2021 · 1 comment
Labels
non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE!

Comments

@justingrant
Copy link
Collaborator

This issue follows up on #1768 where @ptomato had a good idea: use existing ISO tests to cover non-ISO code by using calendar: 'gregory' which returns the same results (if year > 1) but executes the non-ISO polyfill code.

For datemath.mjs tests, using both calendars was super-easy. But we have hundreds of other tests which could probably leverage the same trick, both in demitasse and Test262. This is a tracking issue for this suggestion.

Notes:

When converting the tests to test262, we should ensure that the iso8601 tests are added to built-ins/Temporal/Calendar but the gregory tests are added to intl402/Temporal/Calendar in test262.

  • Could adding gregory support to these tests be automated, either using codegen as a one-time thing and/or doing like datemath.mjs where both calendars are used?
@ptomato ptomato added the non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! label May 10, 2022
@ptomato
Copy link
Collaborator

ptomato commented Jan 2, 2023

I'll add this to tc39/test262#3002.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE!
Projects
None yet
Development

No branches or pull requests

2 participants